<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 29, 2021 at 4:33 PM Jan Stancek <<a href="mailto:jstancek@redhat.com">jstancek@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:monospace"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 29, 2021 at 9:27 AM Li Wang <<a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 26, 2021 at 8:53 PM Jan Stancek <<a href="mailto:jstancek@redhat.com" target="_blank">jstancek@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">When empty set is passed to MPOL_PREFERRED, memory is allocated<br>
on the node of the CPU that triggered the allocation.<br>
<br>
After kernel commit:<br>
7858d7bca7fb ("mm/mempolicy: don't handle MPOL_LOCAL like a fake MPOL_PREFERRED policy")<br>
kernel returns stored policy as MPOL_LOCAL.<br></blockquote><div><br></div><div><div style="font-size:small">As the MPOL_LOCAL has been setup as a real policy, I'm wondering should we</div><div style="font-size:small">add more tests for it in the next? e.g.</div></div></div></div></blockquote><div><br></div><div><div style="font-family:monospace">Right, but we also need something in setup to avoid running it</div><div style="font-family:monospace">for kernels that don't support
MPOL_LOCAL.</div></div></div></div></blockquote><div> </div><div><span class="gmail_default" style="font-size:small">+1 we can achieve that in a separate patch.</span> </div><div><br></div><div><div class="gmail_default" style="font-size:small">I'm also planning to add one more function which named mbind_policy_name()</div><div class="gmail_default" style="font-size:small">in the mbind.h to help make the log more readable, just like what we did in:</div><div class="gmail_default" style="font-size:small"> static inline const char *mbind_flag_name(unsigned flag)</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">And yes, we can do that separately.</div><div class="gmail_default" style="font-size:small"></div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><div style="font-family:monospace"><br></div><div style="font-family:monospace">You're right that parameters in tst_res message appear to be in wrong order.<br></div></div></div></div></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Feel free to fix it while merging this patch.</div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>