<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Cyril,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Taken a note for future, thanks!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-Bogdan</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Cyril Hrubis <chrubis@suse.cz><br>
<b>Sent:</b> Wednesday, August 4, 2021 17:39<br>
<b>To:</b> Bogdan Lezhepekov <bogdan.lezhepekov@suse.com><br>
<b>Cc:</b> ltp@lists.linux.it <ltp@lists.linux.it><br>
<b>Subject:</b> Re: [LTP] [PATCH v3] shmget02: check if CONFIG_HUGETLBFS enabled in kernel</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi!<br>
Pushed with a minor change, thanks.<br>
<br>
The inline variable definition is valid on in C99 and we still have to<br>
support old distributions that compile LTP with GNU89 which does not<br>
allow it. I've also changed the type to unsigned in order to avoid a<br>
warning.<br>
<br>
Full diff:<br>
<br>
diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c<br>
index 7856c2b8e..effd33799 100644<br>
--- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c<br>
+++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c<br>
@@ -110,10 +110,11 @@ static void setup(void)<br>
pw = SAFE_GETPWNAM("nobody");<br>
<br>
if (!hugetlbfs_supported()) {<br>
+ unsigned int i;<br>
<br>
tst_res(TINFO, "SHM_HUGETLB not supported by kernel");<br>
<br>
- for (int i = 0; i < ARRAY_SIZE(tcases); i++) {<br>
+ for (i = 0; i < ARRAY_SIZE(tcases); i++) {<br>
if (tcases[i].flags & SHM_HUGETLB)<br>
tcases[i].exp_err = EINVAL;<br>
}<br>
<br>
-- <br>
Cyril Hrubis<br>
chrubis@suse.cz<br>
<br>
</div>
</span></font></div>
</body>
</html>