<div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> The conflict happened early in tst_test.h and I guess some header files<br>
> between line#14 to line#44 probably involves <linux/if.h>, but I'm not sure<br>
> which one is the culprit.<br>
Interesting, really something in in tst_test.h with combination of<br>
lapi/ip_tables.h. This combination is only in 2 tests, setsockopt0{3,8}.c,<br>
setsockopt03.c already had <netinet/in.h>.<br></blockquote><div><br></div>I eventually <span class="gmail_default" style="font-size:small">caught</span><span class="gmail_default" style="font-size:small"> that</span> "tst_capability.h" is the <span class="gmail_default" style="font-size:small">key point.</span></div><div class="gmail_quote"><span class="gmail_default">To includes </span><netinet/in.h><span class="gmail_default" style="font-size:small"> before that can avoid the conflict.</span></div><div class="gmail_quote"><span class="gmail_default" style="font-size:small"><br></span></div><div class="gmail_quote"><span class="gmail_default">But still not sure how it made things broken (i.e. where includes </span> <linux/if.h><span class="gmail_default" style="font-size:small">)</span>.</div><div class="gmail_quote"><br></div><div class="gmail_quote"><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> If we simply put the <netinet/in.h> at the top of tst_test.h, the<br>
> conflict disappears<br>
> as well.<br>
> See experiment commit:<br>
> <a href="https://github.com/wangli5665/ltp/commit/0155df479811d9a51f30e09accb330238607f73d" rel="noreferrer" target="_blank">https://github.com/wangli5665/ltp/commit/0155df479811d9a51f30e09accb330238607f73d</a><br>
<br>
I'd be for adding it there, with comment why it's there. We can prevent problems<br>
with failing another test in the future. (+ remove it from both tests).<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">I'm OK with this fix.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">@Cyril, @Richard, what do you think? any other thoughts?</div></div></div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>