<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:monospace"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 6, 2021 at 4:31 PM Cyril Hrubis <<a href="mailto:chrubis@suse.cz">chrubis@suse.cz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi!<br>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml<br>
> index 2289b9bfbb2e..fa74c312bebb 100644<br>
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml<br>
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml<br>
> @@ -16,10 +16,6 @@<br>
>    <assertion id="5" tag="ref:XSH6:33594:33595 pt:THR"><br>
>      No signal shall be sent if the pthread_kill() function fails.<br>
>    </assertion><br>
> -  <assertion id="6" tag="ref:XSH6:33598:33599 pt:THR"><br>
> -    [ESRCH] No thread could be found corresponding to that specified by<br>
> -    the given thread ID.<br>
> -  </assertion><br>
>    <assertion id="7" tag="ref:XSH6:33600:33600 pt:THR"><br>
>      [EINVAL] The value of the sig argument is an invalid or unsupported<br>
>      signal number.<br>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt<br>
> index 03dc3d5a718a..8cfa3d8b6ba3 100644<br>
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt<br>
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt<br>
> @@ -6,6 +6,5 @@ Assertion     Status<br>
>  3            YES<br>
>  4            IMPLICITLY tested by assertions 6 and 7.<br>
>  5            IMPLICITLY tested by assertions 6 and 7.<br>
> -6            YES<br>
>  7            YES<br>
>  8            WON'T test. No way to interrupt the pthread_kill() call.<br>
<br>
<br>
Shouldn't we just flip the YES to WON'T test in the coverage?<br></blockquote><br></div><div class="gmail_quote">I dropped it because it seemed pointless to keep around wrong assertions.</div><div class="gmail_quote"><div style="font-family:monospace" class="gmail_default">I don't have strong opinion here, I can change it to WON'T.<br></div><br></div><div class="gmail_quote"></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I'm not sure how to maintain the assertions or coverage files to be<br>
honest.<br>
<br>
Otherwise it looks good. The ESRCH return was always a recommendation<br>
and not an requirement.<br>
<br>
-- <br>
Cyril Hrubis<br>
<a href="mailto:chrubis@suse.cz" target="_blank">chrubis@suse.cz</a><br>
<br>
</blockquote></div></div>