<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><font size="4">Hi Petr!</font></p>
<p><font size="4">From my point of view, it would be nice if lapi
code would only </font><font size="4"><font size="4">contain </font>fallback
code, without LTP API that requires tst_test.h or test.h. So it
would be easy to split fallback code from "utilities" headers
containing the most common functionalities to break the test if
fallback functions are failing. This is the case of
lapi/syscalls.h where tst_syscall is defined, but IMHO it should
be defined out, somewhere in a "utils" header imported by
tst_test.h or by tests which requires specific functionalities.<br>
</font></p>
<p><font size="4">This is possible only if all the tests are already
in the new LTP API version tho, since old tests require to be
refactored first.<br>
</font></p>
<p><font size="4">Kind regards,</font></p>
<p><font size="4">Andrea<br>
</font></p>
<div class="moz-cite-prefix">On 1/20/22 13:16, Petr Vorel wrote:<br>
</div>
<blockquote type="cite" cite="mid:YelSqq5cG6JHFtyh@pevik">
<pre class="moz-quote-pre" wrap="">Hi Andrea,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This modification is a first step into the old LTP API replacement and
it has been completed with the following procedure:
- removed ltp_syscall
- replaced ltp_syscall with tst_syscall inside all tests
- reshuffled headers inside tests to import tst_test.h before
lapi/syscalls.h
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">So far we've done cleanup as whole test one by one.
Sure, why not solving one issue once.
Generally LGTM. I'd just appreciate if tst_test.h didn't have to be loaded at
first, but that's a minor issue.
also with these whole tree patches it's a problem that it either breaks some of
other patches (they will not be applicable) or this patch will not be applicable
(if not applied soon after the release).
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>