<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><font size="4">Hi!</font></p>
<p><font size="4">By changing the file size to 32M, test requires 2
minutes to complete on my machine using ~51MB memory allocation
for 100 threads. We can go for it. I'll also write a little
explanation to the patch.<br>
</font></p>
<p><font size="4">Andrea<br>
</font></p>
<div class="moz-cite-prefix">On 1/20/22 16:31, Cyril Hrubis wrote:<br>
</div>
<blockquote type="cite" cite="mid:YemAQcXuJMGLh%2Fkc@yuki">
<pre class="moz-quote-pre" wrap="">Hi!
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Andrea Cervesato <a class="moz-txt-link-rfc2396E" href="mailto:andrea.cervesato@suse.de"><andrea.cervesato@suse.de></a>
---
runtest/ltp-aiodio.part4 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/runtest/ltp-aiodio.part4 b/runtest/ltp-aiodio.part4
index fc1e1d479..8c10f67fb 100644
--- a/runtest/ltp-aiodio.part4
+++ b/runtest/ltp-aiodio.part4
@@ -62,7 +62,7 @@ DIT002 dio_truncate
#Running read_checkzero
#gread_checkzero
#Running dio_read
-DOR000 dio_read -n 1 -i 100
-DOR001 dio_read -n 10 -i 30
-DOR002 dio_read -n 20 -i 15
-DOR003 dio_read -n 100 -i 4
+DOR000 dio_read -n 1 -i 100 -r 512k -w 512k -s 5M
+DOR001 dio_read -n 10 -i 30 -r 512k -w 512k -s 5M
+DOR002 dio_read -n 20 -i 15 -r 512k -w 512k -s 5M
+DOR003 dio_read -n 100 -i 4 -r 512k -w 512k -s 5M
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Limiting the child buffer to 512k makes sense, at least in the cases
where n > 1 as by default the child allocates 32MB buffer, with 100
children that makes up to ~3GB. Also this really should have been in the
patch description, which should really describe why the changes have
been done.
But I'm not sure about the -s 5M part, the file size was always 128MB
before and reducing it to 5M sounds like too much. On my machine that
reduces the testing time from about one minute to a few seconds, that sounds
like change that is too radical without further explanation. If we want
to run the test with smaller file size I would go for 64M, that reduces
the runtime to half without reducing the changes for triggering a bug
too much.
</pre>
</blockquote>
</body>
</html>