<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div style="line-height:1.6;font-family:'苹方','微软雅黑','sans-serif';">Yes，but it still be wrong if we use serval TPASS in sub test case.<br><br>Best Regards<br>Yang Xu<br><br><br><br></div><div class="ne-quoted"> <a href="https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=1&name=xuyang_jy_0410&uid=xuyang_jy_0410%40163.com&iconUrl=https%3A%2F%2Fmail-online.nosdn.127.net%2Fqiyelogo%2FdefaultAvatar.png&items=%5B%22%E9%82%AE%E7%AE%B1%EF%BC%9Axuyang_jy_0410%40163.com%22%5D" style="display:block;background:#fff; max-width: 400px; _width: 400px;padding:15px 0 10px 0;text-decoration: none; outline:none;-webkit-tap-highlight-color:transparent;-webkit-text-size-adjust:none !important;text-size-adjust:none !important;">
<table cellpadding="0" style="width: 100%; max-width: 100%; table-layout: fixed; border-collapse: collapse;color: #9b9ea1;font-size: 14px;line-height:1.3;-webkit-text-size-adjust:none !important;text-size-adjust:none !important;">
<tbody style="font-family: 'PingFang SC', 'Hiragino Sans GB','WenQuanYi Micro Hei', 'Microsoft Yahei', '微软雅黑', verdana !important; word-wrap:break-word; word-break:break-all;-webkit-text-size-adjust:none !important;text-size-adjust:none !important;">
<tr>
<td width="38" style="padding:0; box-sizing: border-box; width: 38px;">
<img width="38" height="38" style="vertical-align:middle; width: 38px; height: 38px; border-radius:50%;" src="https://mail-online.nosdn.127.net/qiyelogo/defaultAvatar.png">
</td>
<td style="padding: 0 0 0 10px; color: #31353b;">
<div style="font-size: 16px;font-weight:bold; width:100%; white-space: nowrap; overflow:hidden;text-overflow: ellipsis;">xuyang_jy_0410</div>
</td>
</tr>
<tr width="100%" style="font-size: 14px !important; width: 100%;">
<td colspan="2" style="padding:10px 0 0 0; font-size:14px !important; width: 100%;">
<div style="width: 100%;font-size: 14px !important;word-wrap:break-word;word-break:break-all;">邮箱：xuyang_jy_0410@163.com</div>
</td>
</tr>
</tbody>
</table>
</a><html><body><p style="border-top:1px solid #e5e5e5;padding-top: 8px; font-size: 12px; color:#b6b8bb;line-height: 1.833;">签名由 <a href="https://mail.163.com/dashi/dlpro.html?from=mail88" style="color:#6aa8f6;text-decoration: none">网易邮箱大师</a> 定制</p></body></html><blockquote id="ntes-andriodmail-quote" style="margin:0px !important;padding:0px !important;border: none !important;"><blockquote id="ntes-andriodmail-quote" style="margin:0px !important;padding:0px !important;border: none !important;"><div class="J-reply" style="background-color:#f2f2f2;color:black;padding-top:6px;padding-bottom:6px;border-radius:3px;-moz-border-radius:3px;-webkit-border-radius:3px;margin-top:45px;margin-bottom:20px;">
<div style="font-size:14px;line-height:1.5;word-break:break-all;margin-left:10px;margin-right:10px">On <span class="mail-date">01/30/2022 14:09</span>, <a class="mail-to" style="text-decoration:none;color:#2a97ff;" href="mailto:liwang@redhat.com">Li Wang</a> wrote:</div>
</div>On Sun, Jan 30, 2022 at 11:44 AM xuyang2018.jy@fujitsu.com
<br><xuyang2018.jy@fujitsu.com> wrote:
<br>>
<br>> Hi Petr
<br>> > We count only tests which TCONF. In case tst_brk() some tests might be
<br>> > skipped without even trying to run them), thus print them.
<br>> >
<br>> > Signed-off-by: Petr Vorel<pvorel@suse.cz>
<br>> > ---
<br>> > Hi,
<br>> >
<br>> > probably quite confusing to have "skipped" and "not run".
<br>> > Maybe rename s/skipped/cancelled/ and s/not run/skipped/ ?
<br>> > Or just to increase cound of skipped?
<br>
<br>Both fine to me, I slightly think "not-run" might more precise to describe that.
<br>
<br>> >
<br>> > E.g. instead of:
<br>> >
<br>> > bind05.c:132: TCONF: socket(10, 2, 0) failed: EAFNOSUPPORT (97)
<br>> >
<br>> > Summary:
<br>> > passed 8
<br>> > failed 0
<br>> > broken 0
<br>> > skipped 1
<br>> > warnings 0
<br>> > not run 5
<br>> >
<br>> > have
<br>> > bind05.c:132: TCONF: socket(10, 2, 0) failed: EAFNOSUPPORT (97)
<br>> >
<br>> > Summary:
<br>> > passed 8
<br>> > failed 0
<br>> > broken 0
<br>> > skipped 6
<br>> > warnings 0
<br>> >
<br>> > Kind regards,
<br>> > Petr
<br>> >
<br>> > lib/tst_test.c | 3 +++
<br>> > 1 file changed, 3 insertions(+)
<br>> >
<br>> > diff --git a/lib/tst_test.c b/lib/tst_test.c
<br>> > index 844756fbd7..e5ea9e6165 100644
<br>> > --- a/lib/tst_test.c
<br>> > +++ b/lib/tst_test.c
<br>> > @@ -811,6 +811,9 @@ static void do_exit(int ret)
<br>> > fprintf(stderr, "broken %d\n", results->broken);
<br>> > fprintf(stderr, "skipped %d\n", results->skipped);
<br>> > fprintf(stderr, "warnings %d\n", results->warnings);
<br>> > + fprintf(stderr, "not run %d\n", tst_test->tcnt -
<br>> > + results->passed - results->failed - results->broken -
<br>> > + results->skipped - results->warnings);
<br>> IMO, these values are not necessary related. Refer to quotactl01.c(
<br>> tst_test->tcnt is less than results->passed)
<br>
<br>That's because of the test looping 'tst_variant + 1' times.
<br>Maybe we can just multiply it eliminate the distractions?
<br>
<br> tst_test->tcnt * (tst_variant + 1)
<br>
<br>
<br>>
<br>> Also, if you want to add a new tag, you should define the situation for it.
<br>
<br>Theoritically yes, but the problem here is hard to count the
<br>not-run numbers. Because some of the test items will never
<br>be performed if test return by test environment unmatch.
<br>I'm sure we have quite lot of test doing like that.
<br>
<br>
<br>>
<br>> Best Regards
<br>> Yang Xu
<br>>
<br>> > }
<br>> >
<br>> > do_cleanup();
<br>>
<br>> --
<br>> Mailing list info: <a href="https://lists.linux.it/listinfo/ltp">https://lists.linux.it/listinfo/ltp</a>
<br>>
<br>
<br>
<br>--
<br>Regards,
<br>Li Wang
<br>
<br>
<br>--
<br>Mailing list info: <a href="https://lists.linux.it/listinfo/ltp">https://lists.linux.it/listinfo/ltp</a>
<br></blockquote></blockquote></div>
</body>
</html>