<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Hi all,</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
I didn't go for CONFIG_SWAP just because wanted to be aligned with syscalls/swapon/swapon03.c and to not multiply patterns.
<br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
If you see CONFIG_SWAP more beneficial for docparser, I can make another patch. <br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Should I?</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Cheers,</div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Bogdan<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> ltp <ltp-bounces+bogdan.lezhepekov=suse.com@lists.linux.it> on behalf of xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com><br>
<b>Sent:</b> Friday, February 11, 2022 3:21<br>
<b>To:</b> Li Wang <liwang@redhat.com><br>
<b>Cc:</b> LTP List <ltp@lists.linux.it><br>
<b>Subject:</b> Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Li<br>
><br>
><br>
> On Fri, Feb 11, 2022 at 12:09 AM Cyril Hrubis <chrubis@suse.cz<br>
> <<a href="mailto:chrubis@suse.cz">mailto:chrubis@suse.cz</a>>> wrote:<br>
><br>
> Hi!<br>
> Applied, thanks.<br>
><br>
> I guess that the SAFE_OPEN() caused TBROK on machines without<br>
> CONFIG_SWAP, right?<br>
><br>
><br>
> If so, why not go fix with .needs_config for "CONFIG_SWAP=y" ?<br>
+1, it is also friendly to docparse.<br>
<br>
ps: I never listen user complaint for the lack of CONFIG_PORC, so only <br>
using .needs_config for "CONFIG_SWAP=y" can work well.<br>
<br>
Best Regards<br>
Yang Xu<br>
><br>
> --<br>
> Regards,<br>
> Li Wang<br>
><br>
><br>
><br>
><br>
<br>
-- <br>
Mailing list info: <a href="https://lists.linux.it/listinfo/ltp">https://lists.linux.it/listinfo/ltp</a><br>
<br>
</div>
</span></font></div>
</body>
</html>