<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Luke,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks for looking back and working on this.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 3, 2022 at 5:38 AM Luke Nowakowski-Krijger <<a href="mailto:luke.nowakowskikrijger@canonical.com">luke.nowakowskikrijger@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Li, <br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 24, 2022 at 1:44 AM Li Wang <<a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Luke Nowakowski-Krijger <<a href="mailto:luke.nowakowskikrijger@canonical.com" target="_blank">luke.nowakowskikrijger@canonical.com</a>> wrote:<br>
<br>
As we already built the controller files mapping from V2 to V1<br>
in C library and you actually add many new (in patch 5/16).<br>
<br>
I'm thinking maybe we could make use of it in tst_cgctl.c to<br>
avoid handling these (in shell) separately.<br>
<br>
Something like:<br>
<br>
# ./tst_cgctl set "$pid" "cgroup.procs" "$target_pid"<br>
# ./tst_cgctl set "$pid" "memory.max" "$ACTIVE_MEM_LIMIT"<br>
<br>
Otherwise, it seems to make no sense to add so many new<br>
files mapping (like that patch 5/16) at this moment.<br>
<br>
What do you think?<br>
<br>
<br></blockquote><div>I think this would be nice except that we would need to keep track of the tst_cg_cgroup structs if we wanted to use safe_cg_* functions in the C lib. This would be fine if we only wanted to use control files in the test_dir but it gets more complicated if there are other directories below it that we would want to set. At least as far as I understand it.<br></div></div></div></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Right, but so far it seems we don't have more (than two) sub-layer directories tests.</div><div class="gmail_default" style="font-size:small">(or maybe I didn't aware that we have)</div><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div><br></div><div>And as Richard mentioned its probably a better idea to just only add the control files for controllers as we absolutely need them so this wouldn't be too useful. Plus I think it's easy enough from shell to do a version check and write to the right control file/directory directly.</div><div><br></div><div>So I personally don't think its as important, but I could see in the future implementing something like this so it mimics the C api. What do you think?</div></div></div></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Yes, it will be a little bit complex to achieve if we decide to</div><div class="gmail_default" style="font-size:small">encapsulate more details in tst_cgctl.c.</div><div class="gmail_default" style="font-size:small">But I just hope to provide a simple enough and intuitive way</div><div class="gmail_default" style="font-size:small">to use CGroup to LTP shell users. Giving more flexible to shell</div><div class="gmail_default" style="font-size:small">API also means giving more complexity to handle problem and</div><div class="gmail_default" style="font-size:small">easy to make mistakes.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Anyway, I don't strongly insist on going like that, feel free to send</div><div class="gmail_default" style="font-size:small">out the next patch version as you wanted. I believe we will keep</div><div class="gmail_default" style="font-size:small">improving the API and tests later, or we can change to that if we</div><div class="gmail_default" style="font-size:small">find it is really neccesary. </div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>