<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><font size="4">Hi Petr,</font></p>
<p><font size="4">I can check it, but it will probably take some
time because I'm not familiar with that particular scenario. Can
we go ahead with the patch-set anyway?</font></p>
<p><font size="4">Andrea</font><br>
</p>
<div class="moz-cite-prefix">On 3/23/22 13:54, Petr Vorel wrote:<br>
</div>
<blockquote type="cite" cite="mid:YjsYg2u82uLdxDTN@pevik">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi!
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">./userns08 -i50
tst_kconfig.c:82: TINFO: Parsing kernel config '/proc/config.gz'
tst_test.c:1456: TINFO: Timeout per run is 0h 05m 00s
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13)
userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13)
userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13)
userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13)
userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13)
userns08.c:36: TBROK: clone3 failed: ENOSPC (28)
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Something needs to be closed after each run.
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">ENOSPC means that we created too many user namespaces. The problem is
likely that we are creating the namespaces faster than they are being
asynchronously cleaned up in the kernel. Adding sleep(1) to the
clone_newuser() function gives kernel enough time to clean the
namespaces and the test works with any -i. Also note that we get the
exact same failure if we execute the test a few times in a row, i.e.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">for i in `seq 10`; do
./userns08
done
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">+1
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">The original test fails in the same way, so while it should be fixed,
it's not really reason to block this patchset.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Agree (I forget to write I suspected the problem wasn't new in this patchset).
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">And the only correct fix would be retrying the clone() on ENOSPC in the
SAFE_CLONE().
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">+1. I suppose Andrea will have look into it (otherwise I'll do it).
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>