<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><font size="4">Hi Petr,</font></p>
<p><font size="4">sure you can merge. Thanks!</font></p>
<p><font size="4">Andrea</font><br>
</p>
<div class="moz-cite-prefix">On 4/19/22 09:22, Petr Vorel wrote:<br>
</div>
<blockquote type="cite" cite="mid:Yl5jM+a7yGtVpaIG@pevik">
<pre class="moz-quote-pre" wrap="">Hi Andrea,
Reviewed-by: Petr Vorel <a class="moz-txt-link-rfc2396E" href="mailto:pvorel@suse.cz"><pvorel@suse.cz></a>
2 small things:
Actually adding one more #ifdef HAVE_LIBCAP
might be better than calling tst_brk() manually (this is better than my previous
suggestion):
#include "config.h"
#ifdef HAVE_LIBCAP
# define TST_NO_DEFAULT_MAIN
#endif
#include "tst_test.h"
#ifdef HAVE_LIBCAP
#include <string.h>
#include <sys/wait.h>
#include <sys/capability.h>
int main(int argc, char *argv[])
{
...
}
#else
TST_TEST_TCONF("System is missing libcap");
#endif
But if you prefer to original version (define main), then TCONF should be used.
Also #define _GNU_SOURCE is not needed, it should be dropped.
If you agree, I can merge it with proposed changes.
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>