<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Cyril Hrubis <<a href="mailto:chrubis@suse.cz" target="_blank">chrubis@suse.cz</a>> wrote:<br></div><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi!<br>
> I run a quick test for verifying those patches with the latest mainline kernel.<br>
> Apart from these two tiny issues, the result looks good.<br>
<br>
Can we merge the patchset now?<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">I think yes, at least my test shows it is safe.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
There are three things that should be fixed over the latest version,<br>
that are:<br>
<br>
- the heartbeat() call after each test for .tcnt<br>
- the missing runtime for fuzzy sync<br>
- default to something more sane in mmap3 and fix the runtest file<br>
(could be ammended to the convert mmap3 patch as well)<br>
<br>
Should I send v4 after all?<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">No need, unless someone explicitly explains they will do a review/test for V4.</div></div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>