<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><font size="4">Hi Petr,</font></p>
<p><font size="4">that was missing from the previous implementation
indeed. Something that was checked in the other tests, but not
this one. Probably because it's also the older test we refactor
in the aiodio testing suite. It seems related to the bug and the
volatile variable, so I added it as well.<br>
</font></p>
<p><font size="4">Andrea</font><br>
</p>
<div class="moz-cite-prefix">On 5/20/22 09:30, Petr Vorel wrote:<br>
</div>
<blockquote type="cite" cite="mid:YodDo1PKnlGhTNgv@pevik">
<pre class="moz-quote-pre" wrap="">Hi Andrea,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">--- a/testcases/kernel/io/ltp-aiodio/dio_append.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
@@ -19,7 +19,7 @@
#include "tst_test.h"
#include "common.h"
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-static int *run_child;
+static volatile int *run_child;
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> static char *str_numchildren;
static char *str_writesize;
@@ -49,7 +49,10 @@ static void setup(void)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> static void cleanup(void)
{
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP((void *)run_child, sizeof(int));
+ }
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">nit: This looks like unrelated, right? If yes it could be in separate commit.
But I'm ok to merge it in single commit.
Reviewed-by: Petr Vorel <a class="moz-txt-link-rfc2396E" href="mailto:pvorel@suse.cz"><pvorel@suse.cz></a>
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>