<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Petr, All,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 29, 2022 at 7:40 PM Petr Vorel <<a href="mailto:pvorel@suse.cz" target="_blank">pvorel@suse.cz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Cyril,<br>
<br>
> Hi!<br>
> > This patchset require to be on the top of:<br>
<br>
> > [RFC,1/1] API: Allow to use xfs filesystems < 300 MB<br>
> > <a href="https://lore.kernel.org/ltp/20220817204015.31420-1-pvorel@suse.cz/" rel="noreferrer" target="_blank">https://lore.kernel.org/ltp/20220817204015.31420-1-pvorel@suse.cz/</a><br>
> > <a href="https://patchwork.ozlabs.org/project/ltp/patch/20220817204015.31420-1-pvorel@suse.cz/" rel="noreferrer" target="_blank">https://patchwork.ozlabs.org/project/ltp/patch/20220817204015.31420-1-pvorel@suse.cz/</a><br>
<br>
> I'm not that sure if we want to run tests for xfs filesystem that is<br>
> smaller than minimal size used in production. I bet that we will cover<br>
> different codepaths that eventually end up being used in production<br>
> that way.<br>
<br>
> > LTP community: do we want to depend on this behavior or we just increase from 256MB to 301 MB<br>
> > (either for XFS or for all). It might not be a good idea to test size users are required<br>
> > to use.<br>
<br>
> It might *not*? <confused><br>
Again, I'm sorry, missing another not. I.e. I suppose normal users will not try<br>
to go below 301MB, therefore LTP probably should not do it either. That's why<br>
RFC.<br>
<br>
@Darrick, others (kernel/LTP maintainers, embedded folks) WDYT?<br>
<br>
I'm personally OK to use 300 MB (safer to use code paths which are used in<br>
production), it's just that for older kernels even with xfs-progs installed it's<br>
unnecessary boundary. We could base XFS size on runtime kernel, but unless it's<br>
300 MB a real problem for anybody I would not address it. i.e. is there anybody<br>
using XFS on old kernels? (old LTS, whey sooner or later need to use these<br>
variables themselves).<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Another compromised way I can think of is to let LTP choose</div><div class="gmail_default" style="font-size:small">300MB for XFS by default, if the test bed can't provide that size,</div><div class="gmail_default" style="font-size:small">simply go back to try 16MB. Does this sound acceptable?</div><div><br></div></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>