<div dir="ltr"><div>Hey Petr, Cyril,</div><div dir="ltr"><br></div><div dir="ltr">I'm second-guessing how to handle the off_t and int comparisons in mem/mmapstress01 and 10.  Would it have been better to do the following?</div><div dir="ltr"><div><br></div><div>diff --git a/testcases/kernel/mem/mmapstress/mmapstress01.c b/testcases/kernel/mem/mmapstress/mmapstress01.c<br>index f425c223d..934e83006 100644<br>--- a/testcases/kernel/mem/mmapstress/mmapstress01.c<br>+++ b/testcases/kernel/mem/mmapstress/mmapstress01.c<br>@@ -143,7 +143,6 @@ int main(int argc, char *argv[])<br>        pid_t pid;<br>        uchar_t *buf = NULL;<br>        unsigned int seed;<br>-       int pagesize = sysconf(_SC_PAGE_SIZE);<br>        float alarmtime = 0;<br>        struct sigaction sa;<br>        unsigned i;<br>@@ -154,8 +153,10 @@ int main(int argc, char *argv[])<br>        time_t t;<br> #ifdef LARGE_FILE<br>        off64_t bytes_left;<br>+       off64_t pagesize = sysconf(_SC_PAGE_SIZE);<br> #else /* LARGE_FILE */<br>        off_t bytes_left;<br>+       off_t pagesize = sysconf(_SC_PAGE_SIZE);<br> #endif /* LARGE_FILE */<br>        const char *filename = "mmapstress01.out";<br><br>@@ -310,7 +311,7 @@ int main(int argc, char *argv[])<br>                anyfail();<br>        }<br>        for (bytes_left = filesize; bytes_left; bytes_left -= c) {<br>-               write_cnt = MIN(pagesize, (int)bytes_left);<br>+               write_cnt = MIN(pagesize, bytes_left);<br>                if ((c = write(fd, buf, write_cnt)) != write_cnt) {<br>                        if (c == -1) {<br>                                perror("write error");<br>diff --git a/testcases/kernel/mem/mmapstress/mmapstress10.c b/testcases/kernel/mem/mmapstress/mmapstress10.c<br>index 53f02c1f6..1756f7081 100644<br>--- a/testcases/kernel/mem/mmapstress/mmapstress10.c<br>+++ b/testcases/kernel/mem/mmapstress/mmapstress10.c<br>@@ -171,7 +171,6 @@ int main(int argc, char *argv[])<br>        pid_t wr_pid = 0;<br>        uchar_t *buf = NULL;<br>        unsigned int seed;<br>-       int pagesize = sysconf(_SC_PAGE_SIZE);<br>        float alarmtime = 0;<br>        struct sigaction sa;<br>        unsigned i;<br>@@ -182,8 +181,10 @@ int main(int argc, char *argv[])<br>        time_t t;<br> #ifdef LARGE_FILE<br>        off64_t bytes_left;<br>+       off64_t pagesize = sysconf(_SC_PAGE_SIZE);<br> #else /* LARGE_FILE */<br>        off_t bytes_left;<br>+       off_t pagesize = sysconf(_SC_PAGE_SIZE);<br> #endif /* LARGE_FILE */<br><br>        progname = *argv;<br>@@ -360,7 +361,7 @@ int main(int argc, char *argv[])<br>        }<br><br>        for (bytes_left = filesize; bytes_left; bytes_left -= c) {<br>-               write_cnt = MIN(pagesize, (int)bytes_left);<br>+               write_cnt = MIN(pagesize, bytes_left);<br>                if ((c = write(fd, (char *)buf, write_cnt)) != write_cnt) {<br>                        if (c == -1) {<br>                                perror("write error");</div><div><br></div><div>Thanks,</div><div>Edward</div></div></div>