[barcode] DESTDIR support patch for GNU barcode

[Daniel Macks]

On Sun, Feb 26, 2006 at 01:11:07AM -0800, Claudio Fontana wrote:
> 
> I am providing here a patch to support DESTDIR in GNU
> barcode build system.
[...]
> I would also suggest avoiding the use of directories
> as the second argument of install scripts invocation,
> because it can have undesired effects in some edge
> conditions (ref: GNU coding standards 7.2.3 Variables
> for Specifying Commands).
> 
> Attached: barcode.DESTDIR_support.p0.udiff
> Apply from $top_srcdir with:
> patch -p0 < barcode.DESTDIR_support.p0.udiff

Switching to 7.2.3 compliance reveals a weakness in how barcode.info
is handled:

INFO = doc/$(TARGET).info
$(INSTALL) -c -m 0644  $(INFO) $(DESTDIR)$(INFODIR)/$(INFO)

so it goes into $INFODIR/doc/ not $INFODIR itself. Better to have the
$(INSTALL) command specify the local (source) location, not the
variables:

INFO = $(TARGET).info
$(INSTALL) -c -m 0644  doc/$(INFO) $(DESTDIR)$(INFODIR)/$(INFO)

dan

-- 
Daniel Macks
dmacks@netspace.org
http://www.netspace.org/~dmacks