gpm 1.19.4 X Raw Hide version

Nico Schottelius nicos@pcsystems.de
Sun, 09 Sep 2001 21:12:12 +0200


Hello Fr=E9d=E9ric and everybody else!



> Hi Nico. What do you think about the attached patches ? All
> are in Red Hat's Raw Hide 1.19.3-20. BTW, I don't use Red
> Hat, but compiled their version on my system. Please, let me
> know if they're OK, and which will be applied in the official
> release.
>
>    gpm-1.19.1-secenhance.patchName: gpm-1.19.1-secenhance.patch
>                               Type: Plain Text (text/plain)

applied.

>
>    gpm-1.19.2-limits.patchName: gpm-1.19.2-limits.patch
>                           Type: Plain Text (text/plain)

OPEN_MAX is defined in linux/limits.h.
So we can use it. Short: refused/already applied.

>
>    gpm-1.19.3-devfs.patchName: gpm-1.19.3-devfs.patch
>                          Type: Plain Text (text/plain)

refused. why shouldn't we use /dev/console ? It still exists in devfs.
the #if 1 is removed in the next release.
May

>    gpm-1.19.3-docfix.patchName: gpm-1.19.3-docfix.patch
>                           Type: Plain Text (text/plain)

partly manually applied.
What's against 'plug & pray ' ? :)


>    gpm-1.19.3-noworldwrite.patchName: gpm-1.19.3-noworldwrite.patch
>                                 Type: Plain Text (text/plain)

nothing applied. parts where also senseless:

+      unlink(tmp_pidfile);

unlink the pidfile of another running gpm!
refused.

>    gpm-1.19.3-root.patchName: gpm-1.19.3-root.patch
>                         Type: Plain Text (text/plain)

why should we not use
install -o root -m 755 XX bindir/XX ?
refused.

>    gpm-1.19.3-serialconsole.patchName: gpm-1.19.3-serialconsole.patch
>                                  Type: Plain Text (text/plain)

I don't know much about serialconsole.
Do we really need so much code for the serial
console ? Where's the matter with the normal code ?
delayed until someone helps me with serialconsole (maybe you ?).


>    gpm-nops.patchName: gpm-nops.patch
>                  Type: Plain Text (text/plain)

There are more problems with the doc than just the ps file.
There is a big need of new structure.
I will keep the patch in mind, but will not apply it.


>    gpm-root.patchName: gpm-root.patch
>                  Type: Plain Text (text/plain)

There are still some unclear things regarding to gpm-root.y.
So this patch is delayed into patches/tobedone.


Nico