[LTP] [PATCH 1/2] preadv/preadv01.c: add new testcase

Cyril Hrubis chrubis@suse.cz
Wed Nov 4 12:51:14 CET 2015


Hi!
> Hi!
> Thank you for reply!

Can you pretty please set you email cliend to prefix quoted text in the
reply?

https://en.wikipedia.org/wiki/Posting_style#Quoted_line_prefix

> > +# FIXME (garrcoop): more messy format strings.
> > +CPPFLAGS		+= -Wno-error
> 
> This workaround should be needed at all.
> 
> > +%_64: CPPFLAGS += -D_FILE_OFFSET_BITS=64
> > +
> > +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
> ...
> 
> Do you mean that this workaround can be removed ? I will remove it.

LTP is not build with -Werror hence there is absolutely no need to add
-Wno-error to CPPFLAGS.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list