[LTP] [PATCH] containers/netns/netns_sysfs.sh:load dummy module before collecting sysfs interface

[Cyril Hrubis]

Hi!
> >> diff --git a/testcases/kernel/containers/netns/netns_sysfs.sh b/testcases/kernel/containers/netns/netns_sysfs.sh
> >> index 7dea52b..b5791bd 100755
> >> --- a/testcases/kernel/containers/netns/netns_sysfs.sh
> >> +++ b/testcases/kernel/containers/netns/netns_sysfs.sh
> >> @@ -47,6 +47,10 @@ if [ $? -eq 1 ]; then
> >>   	tst_brkm TBROK "unable to create a new network namespace"
> >>   fi
> >>   TST_CLEANUP=cleanup
> >> +
> >> +#Load dummy module before collecting sysfs interface
> >> +lsmod | grep dummy || modprobe dummy
> >> +[ $? -eq 0 ] || tst_brkm TBROK "failed to load dummy module"
> > But this will fail when dummy wasn't compiled in the kernel, right?
> Yes,if dummy wasn't compiled in the kernel,it will also fail when adding 
> dummy device in the next step:
> ===cut===
> ns_exec $NS_HANDLE $NS_TYPE ip link add $DUMMYDEV type dummy || \
>      tst_brkm TBROK "failed to add a new dummy device"
> ===cut===

I meaned "wasn't compiled as module" i.e. compiled in kernel, sorry for
the confusion. In that case this would work fine but the modprobe would
fail.

> > Since modprobe will exit with 1 when module couldn't be found. So we
> > should either just call 'modprobe dummy' and ignore the return value or
> > change the code to ignore the default dummy interface.
> I prefer 'modprobe dummy' and ignore the return value,because I'm not 
> sure whether there is any other default dummy interface name except 
> "dummy0".

Sounds good to me.

-- 
Cyril Hrubis
chrubis@suse.cz