[LTP] [PATCH V2] controllers/cgroup_fj: fix and clean up

Cedric Hnyda chnyda@suse.com
Thu Nov 5 16:16:00 CET 2015


Hi,

On 11/05/2015 03:02 PM, Cyril Hrubis wrote:
> ...
>> +get_mount_point()
>> +{
>> +	check_point=`grep -w $subsystem /proc/mounts | cut -f 2 | cut -d " " -f2`
> I would do even more specific:
>
> grep -w "^$subsystem"
>
> which would match only lines that begin with word "$subsystem".
>
>
> Otherwise this looks good.
>
Thanks for the review.
The format of /proc/mounts is not stable so it might be better to keep
things like they are.

-- 
Cedric Hnyda



More information about the Ltp mailing list