[LTP] How about set IPsec with ip xfrm?

[Hangbin Liu]

Hi Alexey,

Thanks for reviewing the patch. Please see the comments below.

2015-11-03 22:03 GMT+08:00 Alexey Kodanev <alexey.kodanev@oracle.com>:
> Hi Hangbin,
>
> OK, I've reviewed the icmp tests draft, here are the comments:
>
> * I wouldn't add tst_ipsec() to test_net.sh because this function will only
> be run in IPsec related tests, the rest network tests will include it with
> no good reason. We can move all ipsec related tests to one directory under
> network/stress/ipsec and create common library script there.

OK, I can put it under stress/ns-tools/set_ipsec

>
> * c2x() function can be added to test.sh because it is more or less generic,
> but it should be fixed to print the message in LTP style format.

I'd prefer to keep c2x() with set_ipsec at present. We can move it to
test_net.sh
when someone want to use it.

>
> * Make sure you don't run LTP_RSH directly.

Got it, I will use tst_rhost_run() instead.

>
> * Don't use absolute path to run commands, it can differ from one
> environment to another. They should be in the PATH before the tests start.
> You can verify that particular command is available with tst_check_cmds() in
> the test script.

OK
>
> * icmp_check_connectivity (ping) can be merged to test_net.sh, other network
> test could run it too.

I tried to merge it to test_net.sh. But I found we need to check icmp
connectivity
from remove sometimes. Then I'm not sure how to call a function in
test_net.sh from
remove except source test_net.sh in remote. Or we need to add another parameter
in icmp_check_connectivity() like rhost to run cmd from remote. like

tst_icmp_connectivity/tst_ping rhost IFACE ADDR [SIZE]

or just use it as the old way

tst_rhost_run check_icmpv4_connectivity  IFACE ADDR [SIZE]

Which style do you prefer?

Thanks
Hangbin