[LTP] [PATCH] containers/netns/netns_sysfs.sh:load dummy module before collecting sysfs interface

[Jiri Jaburek]

On 11/09/2015 03:14 PM, Cyril Hrubis wrote:
> Hi!
>> However - wouldn't it be simply easier to add an exception for dummy0
>> during the comparison check? The test operates with iface names other
>> than dummy0, so a possible namespace bug would be found anyway.
>> (See attached diff.)
>>
>> However the (quite possibly) best solution would be a one which cleans
>> up after itself, so maybe the [ -d /sys/module/dummy ] solution with
>> explicit modprobe / modprobe -r would work better.
> 
> Either one works for me.

I would send a patch with the more "clean" solution, but I'm not sure
how to modularize the cleanup function here as I need to add modprobe -r
only if the modprobe was previously done.
Furthermore, doing it that way would make the test impossible to run
multiple times in parallel.

So it boils down to either doing a preemptive modprobe 2>/dev/null or
ignoring dummy[0-9]+, it's up to you. :)

> 
>> diff --git a/testcases/kernel/containers/netns/netns_sysfs.sh b/testcases/kernel/containers/netns/netns_sysfs.sh
>> index 7dea52b..e725a50 100755
>> --- a/testcases/kernel/containers/netns/netns_sysfs.sh
>> +++ b/testcases/kernel/containers/netns/netns_sysfs.sh
>> @@ -47,7 +47,10 @@ if [ $? -eq 1 ]; then
>>  	tst_brkm TBROK "unable to create a new network namespace"
>>  fi
>>  TST_CLEANUP=cleanup
>> -ls /sys/class/net >sysfs_before
>> +
>> +# exclude dummy0 from comparison as it gets automatically created by the
>> +# dummy device driver upon insmod/modprobe (during ip link add)
>> +ls /sys/class/net | grep -v dummy0 >sysfs_before
> 
> Maybe we should do grep -v dummy[0-9].* in order to skipp all dummy
> interfaces if someone changes the number of interfaces created. If we
> decide to go this way.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-containers-netns-exclude-dummy0-from-before-after-co.patch
Type: text/x-patch
Size: 1338 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20151109/7f8a8c7c/attachment-0001.bin>