[LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs

Wei, Jiangang weijg.fnst@cn.fujitsu.com
Wed Nov 25 02:27:26 CET 2015


On Tue, 2015-11-24 at 15:08 +0100, Cyril Hrubis wrote:
> Hi!
> >  		pMsg(ERR, args, "%s: Error = %u\n", args->device,
> >  		     GETLASTERROR());
> > +		FREE(buff);
> >  		return (-1);
> >  	}
> >  
> >  	TargetLBA = Seek(fd, args->start_lba * BLK_SIZE);
> >  	if (TargetLBA != (args->start_lba * (OFF_T) BLK_SIZE)) {
> >  		pMsg(ERR, args, "Could not seek to start position.\n");
> > +		FREE(buf);
>                      ^
> 		     Should be buff
> 
> The code does not even compile after the change, can you please compile
> test your change to avoid typos like this one?
Ok,  I will keep in mind your comment.
Thanks a lot.
> 
> -- 
> Cyril Hrubis
> chrubis@suse.cz
> 


-- 
This message has been scanned for viruses and
dangerous content by Fujitsu, and is believed to be clean.



More information about the Ltp mailing list