[LTP] [PATCH v2] hugetlb: checking if hugepage is supported on target system

Cyril Hrubis chrubis@suse.cz
Thu Nov 26 14:49:08 CET 2015


Hi!
> > forgot "static"?
> >
> 
> no, it will be conflict with the prototype in mem.h and get compiler error
> like:
> -------
> hugemmap05.c:253: error: static declaration of ???cleanup??? follows non-static
> declaration
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:100:
> note: previous declaration of ???cleanup??? was here
> hugemmap05.c:295: error: static declaration of ???setup??? follows non-static
> declaration
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:101:
> note: previous declaration of ???setup??? was here
> make: *** [hugemmap05] Error 1

Why have you added the function into the mem/include/mem.h in the first
place? There is kernel/mem/hugetlb/lib/ directory allready, just make
use of it.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list