[LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers

Cyril Hrubis chrubis@suse.cz
Mon Oct 26 16:29:11 CET 2015


Hi!
> Use 'RUNTIME_VAL','PERIOD_VAL' and 'DEADLINE_VAL' to set attr
> 
> Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
> ---
>  .../syscalls/sched_getattr/sched_getattr01.c       |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> index 267b8b1..bf6c5b6 100644
> --- a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> +++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> @@ -38,9 +38,9 @@ void *run_deadline(void *data LTP_ATTRIBUTE_UNUSED)
>  
>  	/* This creates a 10ms/30ms reservation */
>  	attr.sched_policy = SCHED_DEADLINE;
> -	attr.sched_runtime = 10 * 1000 * 1000;
> -	attr.sched_period = 30 * 1000 * 1000;
> -	attr.sched_deadline = 30 * 1000 * 1000;
> +	attr.sched_runtime = RUNTIME_VAL;
> +	attr.sched_period = PERIOD_VAL;
> +	attr.sched_deadline = DEADLINE_VAL;

Looking at the test it also misses GPL header in a comment. Can you
please send a patch that adds it as well?
(sorry for not catching that earlier)

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list