[LTP] [RFC] [PATCH] lib/tst_mkfs: Exit with TCONF on missing mkfs.foo

[Cyril Hrubis]

Hi!
> diff --git a/lib/tst_run_cmd.c b/lib/tst_run_cmd.c
> index a54d46878940..e58b639e94af 100644
> --- a/lib/tst_run_cmd.c
> +++ b/lib/tst_run_cmd.c
> @@ -71,7 +71,12 @@ int tst_run_cmd_fds_(void (cleanup_fn)(void),
>                         dup2(stderr_fd, STDERR_FILENO);
>                 }
>  
> -               _exit(execvp(argv[0], (char *const *)argv));
> +               if (execvp(argv[0], (char *const *)argv) == -1) {
> +                       if (errno == ENOENT)
> +                               _exit(255);
> +                       else
> +                               _exit(errno);

I'm not 100% sure if we want to set the errno as an exit value since for
instance EPERM == 1 which would be indistinguishable from most of the
command failures.

Maybe we can exit with 255 on ENOENT and with 254 otherwise.

-- 
Cyril Hrubis
chrubis@suse.cz