[LTP] [PATCH 1/2] syscalls/access04: reconstruct and convert to new API

Guangwen Feng fenggw-fnst@cn.fujitsu.com
Fri Aug 5 12:08:35 CEST 2016


Hi!

Thanks for your comments!

On 08/05/2016 12:50 AM, Cyril Hrubis wrote:
> Hi!
> Once we remote the directory the accessfile is in this is just the same
> as access01.c.
> 

Sorry, do you mean once we "remote" the directory? or "remove" the directory?
And I think access04 does a little more: checks if the file exists actually
via stat(), maybe I should add this part(check existence) to access02?

> Looks like the whole point of the test was to put the file into a
> directory and pass the path to the syscall.
> 
> What about we remote this test and add a few more cases with a file in
> subdirectory to the access01 test instead?
> 

OK, I will put this part into access01 and add a few more cases instead, thanks.

Regards,
Guangwen Feng




More information about the ltp mailing list