[LTP] [PATCH] syscalls/fcntl34: Use -D_FILE_OFFSET_BITS=64 for all cases

Cyril Hrubis chrubis@suse.cz
Tue Aug 16 13:31:48 CEST 2016


Hi!
> > Actually both glibc and uClibc use fcntl64 by default and usually
> > fail when you try to pass 32-bit flock structure to it when you
> > use OFD locks. Then fcntl64 fails in fcntl_setlk64 routing while
> > checking l_pid field.
> 
> Given the cleverness glibc applies to flock(), it might be more
> useful for the LTP syscall tests to directly test the system calls
> avoiding the libc wrappers. That way you could know that you've
> definitely tested both flock and flock64 syscalls on platforms
> where they exist.

I guess that we should be testing both. As it stands now we do not test
the 32bit fcntl() at all.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list