[LTP] [PATCH 2/8] waitpid10: use the new API

Stanislav Kholmanskikh stanislav.kholmanskikh@oracle.com
Thu Aug 18 10:25:38 CEST 2016



On 08/15/2016 05:36 PM, Cyril Hrubis wrote:
> Hi!
>> +static void do_child_1(void)
>>  {
> 
> Why do we run the test in the do_child_1() here?
> 
> As far as I remember the whole point was to start some of the child
> processes in different process group and we don't do that in this test,
> so we may as well put this function as the test function into the struct
> tst_test.

waitpid_test() just forks a child - do_child_1() which then does the
actual testing. This scheme is needed in other test cases, since they
operate with process groups.

Yes, here it's redundant, since this do_child_1() doesn't touch process
groups. I decided to use this scheme here just for similarity with other
test cases. In my opinion, it brings no harm or improvements.


> 
> 
> Otherwise this looks good.
> 


More information about the ltp mailing list