[LTP] [PATCH v3 4/4] shell: fix echo -e bashisms, simplify code

[Petr Vorel]

Hi Cyril,

> The tacl_xattr.sh should be probably investigated and either fixed or
> removed.

> The statslogging script seems to be part of pounder21, there are some
> tar archives that contain test screnarios with symlinks that may point
> to the files in the test_scripts directory. So simple git grepping will
> not help in this case.
Good to know.

> The mixed_load.sh seems to be unused, probably leftover.
It would be great if you could do the cleanup.

> > diff --git a/tools/strace_test/slay b/tools/strace_test/slay
> > index a68e8c9..d3571c0 100755
> > --- a/tools/strace_test/slay
> > +++ b/tools/strace_test/slay
> > @@ -115,11 +115,11 @@ do
> >    COOL="1"
> >    if [ "$SLAY_BUTTHEAD" = "on" ]
> >    then
> > -    echo "${ME}: $SIGSHOW is kicking $1's butt!"
> > -    echo -e "\\n\\n\\nI'm kicking your butt.\\n\\n\\n" | write $1 2>/dev/null
> > +    printf "${ME}: $SIGSHOW is kicking $1's butt!\n"
> > +    printf "\\n\\n\\nI'm kicking your butt.\\n\\n\\n\n" | write $1 2>/dev/null
> >    else
> > -    echo "${ME}: Sending $SIGSHOW signal to $1's process(es)..."
> > -    echo -e "\\n\\n\\nYour current session has been terminated.\\n\\n\\n" | \
> > +    printf "${ME}: Sending $SIGSHOW signal to $1's process(es)...\n"
> > +    printf "\\n\\n\\nYour current session has been terminated.\\n\\n\\n\n" | \

> I'm a bit puzzled by the double backslashes here. I guess that the
> double backslash is reduced by shell to a single backslash and then
> echo/printf command gets just plain old \n in ARGV[]. But as this code
> will likely get removed anyway I've applied this patch as it is.
Eh, you (and Peter Maydell) are right. I'm sorry, I'll have to check it twice next time
(especially when I replace with perl one liners).


> Whole series applied, thanks.
Thanks a lot!


Kind regards,
Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20161201/089bc671/attachment.sig>