[LTP] [PATCH V2] Use a union of sigval instead of sigval_t

Jan Stancek jstancek@redhat.com
Thu Jan 7 15:24:01 CET 2016





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: "Khem Raj" <raj.khem@gmail.com>, ltp@lists.linux.it
> Sent: Thursday, 7 January, 2016 3:08:51 PM
> Subject: Re: [LTP] [PATCH V2] Use a union of sigval instead of sigval_t
> 
> Hi!
> > > sigval_t is glibc only construct, we use a union of sigval
> > > which pretty much is same effect as sigval_t
> > > 
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > 
> > Reviewed-by: Jan Stancek <jstancek@redhat.com>
> > 
> > Looks good to me, I think this should be safe to apply before release.
> > (I tested it across RHEL5.6/6.0/7.0)
> > 
> > Cyril, do you agree?
> 
> Looking into POSIX it explicitly says that the callback takes union
> sigval paramter and not sigval_t.
> (http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html)
> 
> So this change should not break anything. Acked to go in before release
> by me as well.

Pushed with 2nd fwd declaration removed too and added POSIX reference
to commit message.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 


More information about the Ltp mailing list