[LTP] [PATCH 2/3] Add knob to control whether numa support should be checked

Cyril Hrubis chrubis@suse.cz
Thu Jan 7 23:24:11 CET 2016


Hi!
> +AC_ARG_WITH([numa],
> +  AC_HELP_STRING([--without-numa],
> +    [without the numa support]),
> +  [],[with_numa=yes],
> +)
> +
>  AC_CONFIG_SUBDIRS([utils/ffsb-6.0-rc2])
>  
>  # END testsuites knobs
> @@ -145,7 +151,9 @@ LTP_CHECK_SELINUX
>  LTP_CHECK_SIGNAL
>  LTP_CHECK_SYSCALL_EVENTFD
>  LTP_CHECK_SYSCALL_MODIFY_LDT
> +if test "x$with_numa" = xyes; then
>  LTP_CHECK_SYSCALL_NUMA
> +fi
>  LTP_CHECK_SYSCALL_QUOTACTL
>  LTP_CHECK_SYSCALL_SIGNALFD
>  LTP_CHECK_SYSCALL_UNSHARE

This is way to ugly. You should add the AC_ARG_WITH() to the
corresponding m4/ltp-numa.m4 file instead.


-- 
Cyril Hrubis
chrubis@suse.cz


More information about the Ltp mailing list