[LTP] [PATCH 2/2] commands/insmod: Added new testcase to test insmod(8)

[Guangwen Feng]

Hi!
Thanks for your review!

On 01/28/2016 12:28 AM, Cyril Hrubis wrote:
> Hi!
>> +setup()
>> +{
>> +	tst_require_root
>> +
>> +	tst_check_cmds rmmod insmod
>> +
>> +	if ! [ -e ./test_insmod01.ko ]; then
>> +		tst_brkm TCONF "'test_insmod01.ko' not found"
>> +	fi
> 
> We should really copy the behavior of tst_module_exist() from C library
> here, i.e. add a function to test.sh that will return a path to the
> module in case that it exists. I can write the function if needed.

I got it.
I will add this to test.sh, thanks.

> 
>> diff --git a/testcases/commands/insmod/test_insmod01.c b/testcases/commands/insmod/test_insmod01.c
> 
> And I would prefix the module name with ltp_ as well so that it's clear
> where it came from.

OK.

> 
> 
> The rest looks good.
>