[LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs

Jan Stancek jstancek@redhat.com
Tue Jul 12 18:10:58 CEST 2016





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Tuesday, 12 July, 2016 3:55:43 PM
> Subject: Re: [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs
> 
> Hi!
> > Docs say that SAFE_CLOSE() sets the passed file descriptor to -1
> > after it's successfully closed, but oldlib SAFE_CLOSE doesn't
> > do that.
> 
> Have you tried to run at least syscalls testsuite after this change?

That was the plan, but I didn't get to that today.

I was thinking syscalls as well, since most common failure seems
to be errno tests, trying to trigger EBADF, etc.

I'll reply once I have results.

Regards,
Jan

> 
> I do not expect that this will break anything, but there it's a possibility.
> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 


More information about the ltp mailing list