Hi! > lib/tests/tst_safe_fileops.c | 40 +++++++++++++++++++++++++++++++++++ The last minor nitpick is that the lib/tests/ directory is full of oldlib tests and this is a newlib test. It may be better to add this file to the lib/newlib_tests/. Anyway this version looks fine, acked. -- Cyril Hrubis chrubis@suse.cz