[LTP] [PATCH] Shell wrappers for the checkpoint interface

Stanislav Kholmanskikh stanislav.kholmanskikh@oracle.com
Thu Jun 9 13:49:17 CEST 2016


Hi!

On 06/08/2016 05:23 PM, Cyril Hrubis wrote:
> Hi!
>> +	if (!type)
>> +		ret = tst_checkpoint_wait(id, timeout);
>> +	else
>> +		ret = tst_checkpoint_wake(id, nr_wake, timeout);
>
> I find it silly that you do negate the flag here. You could have set it
> the other way, or swap the wait and wake in the if and else branch...

I swapped the wait and wake and pushed it.

Thanks!


>
> Anyway the rest looks good to me, ackend.
>


More information about the ltp mailing list