[LTP] [PATCH v2 2/2] numa_helper: add min_nodes parameter to is_numa()

[Jan Stancek]

----- Original Message -----
> From: "Jan Stancek" <jstancek@redhat.com>
> To: "Cyril Hrubis" <chrubis@suse.cz>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 3 March, 2016 3:10:21 PM
> Subject: Re: [LTP] [PATCH v2 2/2] numa_helper: add min_nodes parameter to is_numa()
> 
> 
> 
> ----- Original Message -----
> > From: "Cyril Hrubis" <chrubis@suse.cz>
> > To: "Jan Stancek" <jstancek@redhat.com>
> > Cc: ltp@lists.linux.it, liwang@redhat.com
> > Sent: Thursday, 3 March, 2016 2:35:48 PM
> > Subject: Re: [PATCH v2 2/2] numa_helper: add min_nodes parameter to
> > is_numa()
> > 
> > Hi!
> > > get_allowed_nodes() can fail if callers request more nodes than
> > > are available. This patch changes is_numa() by adding a parameter
> > > to it, which allows to easily check that system supports NUMA and
> > > has at least certain number of nodes and it also updates tests
> > > that used get_allowed_nodes() without checking node count first.
> > 
> > Shouldn't we pass the NH_MEMS/NH_CPUS flags to the is_numa() as well?
> 
> We probably should, we have maybe 1 or 2 tests that care about cpus,
> not just mem. I'll add it.

Pushed with added flag parameter.

Regards,
Jan

> 
> > 
> > Otherwise the patchset looks good to me.
> 
> Thanks for review,
> Jan
> 
> > 
> > --
> > Cyril Hrubis
> > chrubis@suse.cz
> > 
> 
> --
> Mailing list info: http://lists.linux.it/listinfo/ltp
>