[LTP] [PATCH] syscalls/profil01: disable this test for uClibc

[Yuriy Kolerov]

The problem is that an environment variable must be defined to exclude tests for uClibc in Makefiles. And tests must be built by this way (as it done in uClinux):

make UCLIBC=1

Exclusion may be implemented in "testcases/kernel/syscalls/Makefile" like this:

ifeq ($(__UCLIBC__),1)
FILTER_OUT_DIRS	+= profil
endif

So UCLIBC variable must be set explicitly. Is it a right way?

Regards,
Yuriy Kolerov


> -----Original Message-----
> From: Yuriy Kolerov [mailto:ykolerov@synopsys.com]
> Sent: Wednesday, March 09, 2016 12:29 PM
> To: Cyril Hrubis <chrubis@suse.cz>; Yuriy Kolerov
> <yuriy.kolerov@synopsys.com>
> Cc: ltp@lists.linux.it; Vineet.Gupta1@synopsys.com;
> Alexey.Brodkin@synopsys.com; Anton.Kolesov@synopsys.com
> Subject: RE: [LTP] [PATCH] syscalls/profil01: disable this test for uClibc
> 
> Hi Cyril,
> 
> Thanks! I've not noticed it earlier. I will make a proper fix. Indeed there are
> more tests which are excluded for uClibc and uClinux by that ugly way so
> they must be fixed properly in future too.
> 
> Regards,
> Yuriy Kolerov
> 
> > -----Original Message-----
> > From: Cyril Hrubis [mailto:chrubis@suse.cz]
> > Sent: Monday, March 07, 2016 12:54 PM
> > To: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
> > Cc: ltp@lists.linux.it; Vineet.Gupta1@synopsys.com;
> > Alexey.Brodkin@synopsys.com; Anton.Kolesov@synopsys.com
> > Subject: Re: [LTP] [PATCH] syscalls/profil01: disable this test for
> > uClibc
> >
> > Hi!
> > > diff --git a/testcases/kernel/syscalls/profil/profil01.c
> > > b/testcases/kernel/syscalls/profil/profil01.c
> > > index 2fc47aa..c44daa7 100644
> > > --- a/testcases/kernel/syscalls/profil/profil01.c
> > > +++ b/testcases/kernel/syscalls/profil/profil01.c
> > > @@ -39,6 +39,8 @@
> > >  char *TCID = "profil01";
> > >  int TST_TOTAL = 1;
> > >
> > > +#if !defined(__UCLIBC__)
> > > +
> > >  static volatile sig_atomic_t profil_done;
> > >
> > >  static void alrm_handler(int sig)
> > > @@ -124,3 +126,11 @@ int main(int ac, char *av[])
> > >
> > >  	tst_exit();
> > >  }
> > > +
> > > +#else
> > > +int main(void)
> > > +{
> > > +	tst_brkm(TCONF, NULL, "system doesn't have profiling support"); }
> > > +#endif
> >
> > Adding #ifdefs for each platform/libc implementation like this does
> > not really scale.
> >
> > What about handling it the same way we handle UCLINUX in the
> Makefiles?
> >
> > Have a look at:
> >
> > ltp/testcases/kernel/syscalls/Makefile
> > ltp/testcases/kernel/syscalls/writev/Makefile
> >
> > --
> > Cyril Hrubis
> > chrubis@suse.cz