[LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs

Cyril Hrubis chrubis@suse.cz
Wed Mar 9 16:52:58 CET 2016


Hi!
> > Also why have you added the blocksize parameter as well? The block size
> > is needed only for the mmap16 test while limiting filesystem size seems
> > like good addition to the library?
> 
> Block size is needed because some fs need to know the block count, if you
> want to create a sized fs. For example if we want to make 512m ext4 and xfs:
> 
> xfs can directly use mkfs -t xfs -d size=512m device
> 
> but mkfs.ext4 need to do like: mkfs -t ext4 -b $block_size device 512*1024*1024/$block_size
> 
> So we need to know block size for some fs, as I know udf fs need to know block count too.

Looking at the a few different mkfs programs there is no unified way to
pass the size parameter. And looks like only mke2fs and mkfs.fat
supports one paramter after the device.

So after all the easiest solution may be just to add one more const
char* fs-size parameter to tst_mkfs that could be used to pass block
count to these two.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list