[LTP] [PATCH 1/3] lib/test_net.sh: add tst_ping() to check icmp connectivity

[Alexey Kodanev]

Hi,
On 03/10/2016 09:22 AM, Hangbin Liu wrote:
>>>
>>>> +    if [ "$dst_addr" == "$(tst_ipaddr)" ]; then
>>>> +        tst_rhost_run -c "$PING -I $src_iface -c $PING_MAX $dst_addr \
>>>> +            -s $msg_size > /dev/null 2>&1"
>>>> +    else
>>>> +        $PING -I $src_iface -c $PING_MAX $dst_addr -s $msg_size > \
>>>> +            /dev/null 2>&1
>>>> +    fi
>>>> +}
>>> Do we actually need to run this command from remote host?
> I'm OK with both side. but the previous test run check_icmp_connectivity from
> remote.
>
> $LTP_RSH $RHOST ${LTPROOT}/testcases/bin/check_icmpv4_connectivity
>
> So how do you think.

If we're checking connectivity... it doesn't really matter,
but running it from remote host is not so convenient.

Thanks,
Alexey