[LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs

Cyril Hrubis chrubis@suse.cz
Thu Mar 10 15:06:53 CET 2016


Hi!
> > > 2) Generally most QE will prepare some partitions or some special
> > > device(FC, SAS...)
> > > in his test machine, and use them for many different test suit(LTP,
> > > xfstests ...).
> > > These partitions or devices maybe 15G, 80G, 1T, 2T... they always pass them
> > > as test
> > > devices directly. I think we shouldn't say "NO, you can't pass a device
> > > more than
> > > 1G to LTP, that will cause failures.", I think LTP should deal with big
> > > test device
> > > problem, so mkfs_sized is needed.
> > 
> > I do not agree. Since if you do not pass any device to LTP, it will
> > simply create small enough loopback device. So in this case the solution
> > is simply not passing any device to LTP at all.
> 
> Oh, sorry I don't know LTP will create small loop device by itself. So do you
> still want to fix this ETIMEDOUT problem? Or we just say "please don't give
> outside device to LTP?" or "please give a small enough device to LTP -b device"

I still do, since it's reasonably easy to fix and 1GB block device is
not that big to begin with.

> BTW, if LTP will create small loop device by itself, I can't make mmap16 to create
> a 100M ext4. I think it maybe too big for LTP small loop device. I will test and
> change my recent patch

Ah looks like there is a bug. Since the default LTP device size was
changed to 100MB in lib/tst_device.c and in testcases/lib/test.sh but
not in the runltp (which is because new enough btrfs needs at least
100MB for filesystem).

But the mmap16 test should work with as small device as possible, which
would be 20MB.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list