[LTP] [PATCH] lib/tst_rmdir.c: close TESTDIR files before rmobj()

[Cyril Hrubis]

Hi!
> >> NFS creates special .nfs* files when test file was removed and
> >> left open. In that case, tst_rmdir() fails to remove test dirs:
> > This is the reason why we state in test writing guidelines that all open
> > file descriptors should be closed in the cleanup() function.
> 
> Most tests are not doing it and just call tst_rmdir() in cleanup.
> When a testfails in the middle, e.g. with tst_brkm(TFAIL,...),
> it will getworthlessTWARN along with TFAIL.
> 
> Some tests closes fds in cleanup, and it means that they set global vars
> to keep track of open files. I think, itcomplicates a little bit writing
> and reading such tests.So that is why I think it's better to have such
> cleanup operations insidethe library.

I'm not saying this is a bad idea. I'm not 100% sure if there are any
side effects. Maybe we can add a close_fds flag to the test structure in
the new test library and enable it only when it's needed.

-- 
Cyril Hrubis
chrubis@suse.cz