[LTP] [PATCH] max_map_count: fix error by using runtime check

[Cui Bixuan]

在 2016/3/23 18:22, Jan Stancek 写道:


>> -	if (!strcmp(buf, "[vsyscall]"))
>> -		return true;
>> -#elif defined(__ia64__)
>> -	/* On ia64, the vdso is not a proper mapping */
>> -	if (!strcmp(buf, "[vdso]"))
>> -		return true;
>> -#elif defined(__arm__)
>> -	/* Older arm kernels didn't label their vdso maps */
>> -	if (!strncmp(line, "ffff0000-ffff1000", 17))
>> -		return true;
>> -#endif
>> +	if (strstr(un.machine, "x86") != NULL)
>
> What if uname contains i386?
Yes, you are right, I have a mistake.

>
> Can we relax the pass condition to allow map_count to be
> within some tolerance? Then we wouldn't have to worry so much about
> all arch specifics.
Does it influence the case if we relax the pass condition?  I think we 
shuold think about it.

Thanks
Cui Bixuan
>
>

>>   	return false;
>>   }
>> --
>> 1.8.3.4
>>
>> --
>> Mailing list info: https://lists.linux.it/listinfo/ltp
>>
>