[LTP] [PATCHv3 3/3] network/stress/icmp: use ip xfrm for icmp4-uni-basic01 ipsec testing

[Hangbin Liu]

Hi,
On Wed, Mar 23, 2016 at 11:21:37AM +0300, Alexey Kodanev wrote:
> Hi,
> >>>@@ -72,6 +65,7 @@ LINK_NUM=${LINK_NUM:-0}
> >>>  # The version of IP
> >>>  IP_VER=${IP_VER:-4}
> >>>+[ $IP_VER -eq 6 ] && TST_IPV6=6
> >>just "ipv=${TST_IPV6:-4}" instead of two lines.
> >This is not work. Because test_net.sh will set TST_IPV6= , and icmp4-uni-basic01
> >need source it before test. The relation looks like
> >
> >icmp6-uni-basic01
> >   . icmp4-uni-basic01
> >     . ipsec_lib.sh
> >       . test_net.sh
> >
> >If we want to use like ipv=${TST_IPV6:-4}, we need source test_net.sh in all
> >sub-testcases instead of in ipsec_lib.sh. Which will like
> >
> >icmp6-uni-basic01
> >   . test_net.sh
> >   . icmp4-uni-basic01
> >     . ipsec_lib.sh
> 
> Could you add "ipv=..." to ipsec_lib.sh and we wouldn't set it in every
> test-case?

the IP_VER is to describe what the test run for. We shouldn't add it in
ipsec_lib.sh. There is no relations between them.

> 
> BTW, does the attached patch help in the first case (added export to
> TST_IPV6)?

I'm afraid not. I'd tried to use like

icmp4-uni-basic01 icmp4-uni-basic01
icmp6-uni-basic01 icmp4-uni-basic01 -6

Then I find this is not only different of IP version, ipsec protocol, mode. But
also different message sizes. So I give up to use like that.

> 
> 
> >>-# Run a client
> >>-$LTP_RSH $RHOST "${LTPROOT}/testcases/bin/ns-echoclient -S $lhost_addr -f $IP_VER -s \"$ICMP_SIZE_ARRAY\"" &
> >>-
> >>-sleep $NS_DURATION
> >>-killall_icmp_traffic
> >>-wait
> >>+# Make sure the connectvity
> >>+for msg_size in $ICMP_SIZE_ARRAY; do
> >>+    tst_ping $lhost_ifname $rhost_addr $msg_size
> >>+    if [ $? -ne 0 ]; then
> >>+        tst_brkm TBROK "There is no IPv$IP_VER connectivity with msg_size $msg_size"
> >>+    else
> >>+        tst_resm TPASS "There has IPv$IP_VER connectivity with msg_size $msg_size"
> >>+    fi
> >>+done
> >>
> >>Is it really needed to ping with different message sizes? if yes, we
> >>couldadd this
> >>functionality to tst_ping().
> >Yes, we need to make sure ipsec can handle all kinds of message size. But we
> >could not make it in tst_ping because ah/esp and tunnel/transport have
> >different header length. e.g. when there is no ipsec, the max playload is
> >65507. If we test ah + transport, the max playload is 65483. etc. It's hard to
> >make tst_ping to handle all these scenarios.
> 
> I thought we could add variable length parameters, something like this
> 
> tst_ping p1 ... pN $ICMP_SIZE_ARRAY
> 
> tst_ping()
> {
>     local msg_sizes=${@:N+1}
> 
>     for size in msg_sizes; do
>     ...
> }

I think tst_ping() is a unit test to check the connectivity, we do not need to
add everything inside. Most time we only need to make sure the rhost is
online. Let's make the test case deside what message size they want to test.

How to you think?

Thanks
Hangbin
> 
> 
> Best regards,
> Alexey
> 
> >Thanks
> >Hangbin
> 

> From 99f1c6eadacd6b03180fe08fc36eae3725a57341 Mon Sep 17 00:00:00 2001
> From: Alexey Kodanev <alexey.kodanev@oracle.com>
> Date: Wed, 23 Mar 2016 11:11:29 +0300
> Subject: [PATCH] testcases/lib/test_net.sh: export TST_IPV6 var
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
>  testcases/lib/test_net.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/lib/test_net.sh b/testcases/lib/test_net.sh
> index 418fed3..1227265 100644
> --- a/testcases/lib/test_net.sh
> +++ b/testcases/lib/test_net.sh
> @@ -154,7 +154,7 @@ tst_read_opts()
>  	while getopts ":6" opt; do
>  		case "$opt" in
>  		6)
> -			TST_IPV6=6;;
> +			export TST_IPV6=6;;
>  		esac
>  	done
>  	OPTIND=0
> -- 
> 1.7.1
> 

> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp


-- 

Thanks & Best Regards
Hangbin Liu <haliu@redhat.com>
Leo on #kernel-qe, #kernel, #eng-china