[LTP] [PATCH 2/2] pause01: rewrite testcase

Jan Stancek jstancek@redhat.com
Thu May 12 11:11:37 CEST 2016




----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Wednesday, 11 May, 2016 3:21:36 PM
> Subject: Re: [LTP] [PATCH 2/2] pause01: rewrite testcase

> > -static void go(int sig)
> > -{
> > -	(void)sig;
> > +	/*
> > +	 * TST_CHECKPOINT_WAIT has built-in timeout, if pause() doesn't return,
> > +	 * this checkpoint call will reliably end the test.
> > +	 */
> > +	TST_CHECKPOINT_WAIT(0);
> > +	SAFE_WAIT(&status);
> 
> Hmm, maybe it would be better if we add timeout logic to the new test
> library instead of adding it to selected few testcases.

I pushed it with all your suggestions, except for the timeout logic.

Did you have something specific in mind how to implement this?
My first thought was a new field to tst_test struct, and forking
a watchdog process.

Regards,
Jan


More information about the ltp mailing list