[LTP] [PATCH 2/2] syscalls/fanotify*: Cleanup && fix compiler warnings

Cyril Hrubis chrubis@suse.cz
Tue May 17 14:11:21 CEST 2016


Hi!
>  testcases/kernel/syscalls/fanotify/fanotify.h   | 57 -------------------------

Looking at the code indeed the testcases have

#if defined(HAVE_SYS_FANOTIFY_H)

#endif

Around the whole test code so the wrappers are not used at all.

But you should really describe exactly that in the commit description so
that it's clear why this header could be removed.

We may also try to remove the #ifdefs from the testcases so they are
compiled even on glibc 2.12 and older (which is not that old). I guess
is that these testcases will compile fine, but we would have to add
configure check for linux/fanotify.h which would have to be included
before the fanotify wrappers to get the FAN_* constants defined. And
also create fallback definitions or skip the test compilation if both
sys/fanotify.h and linux/fanotify.h was misssing.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list