[LTP] [PATCH v2 1/3] network: merge networktests.sh/networkstress.sh into network.sh

Cyril Hrubis chrubis@suse.cz
Tue May 17 15:53:45 CEST 2016


Hi!
> But if we don't source test.sh we will break some dependencies between 
> test_net.sh and test.sh,
> e.g. variables like this one:
> 
> export RHOST_HWADDRS=${RHOST_HWADDRS:-"$(tst_get_hwaddrs rhost)"}
> 
> It might call tst_brkm/tst_resm...

Ah, missed that one. Then we should go with the v2.

> BTW, if we already using tst_* functions from test.sh, may be we could
> replace network.sh's 'echo' commands there too?

Hmm, that may be a bit confusing since that would make the output look
like an output from a testcase.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list