[LTP] [PATCH] ppoll01: rewrite in new API

Cyril Hrubis chrubis@suse.cz
Tue May 24 14:54:47 CEST 2016


Hi!
> > +static void cleanup(void)
> > +{
> > +	SAFE_CLOSE(fd1);
> > +	SAFE_UNLINK("testfile1");
> 
> ^^ These shouldn't be safe macros. I noticed it too late.

And the close(fd1) should be done only if it was opened.

But otherwise the test looks much better after this patch.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list