[LTP] [PATCH v2 3/3] syscalls/madvise02: reconstruct and convert to new API

Li Wang liwang@redhat.com
Wed May 25 08:17:40 CEST 2016


On Mon, May 23, 2016 at 04:14:18PM +0200, Cyril Hrubis wrote:
> 
> This whole part is a mess. You should not change the content of the
> structure in this way. If there are values that has to be changed on the
> runtime the structure members should be initialized with a pointers to a
> variable and that variable should be set up in the setup().

Good proposals, but this situation are a little bit different.

I failed to decrease the lines of this part. Since madvise02 catch
failures on purpose. It is very hard to divide 'Not Support' with
'Expected Errno' when getting EINVAL msg.

So, I'd like to keep calling a tcases_filter() in test function to
make the testcase working correctly. And move an enable flag as a
global variable.

Patch V3 is coming...

Regards,
Li Wang


More information about the ltp mailing list