[LTP] [PATCH 1/1] Tiny doc fixes

Cyril Hrubis chrubis@suse.cz
Tue Nov 15 17:50:41 CET 2016


Hi!
> > >  static struct tst_test test = {
> > >  	.tid = "getenv01",
> > > -	.test_all = test,
> > > +	.test_all = do_test,
> > >  	.setup = setup,
> > >  };
> 
> > What is wrong with this one?
> Name collision (function test and struct test). I know, it's just a doc...

Ah, right. I guess that we should to fix the example code to compile
cleanly.

> > And even if we decide to change the function name, we should fix it in
> > the text as well:
> 
> > -The test itself is done in the 'test()' function. The test function must work
> > +The test itself is done in the 'do_test()' function. The test function must work
> Sorry, it seems I can't do search and replace :-(.

Well the word test is used in the document so often that you have to
actually read the paragraph to figure out what needs to be updated.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list